chore: bump cometbft version #2207
Closed
+163
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
reviewed
Nov 11, 2024
| @@ -207,7 +208,7 @@ replace github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2 | |||
| replace github.com/rjeczalik/notify => github.com/rjeczalik/notify v0.9.3 | |||
|
|
|||
| // use cometbft | |||
| replace github.com/tendermint/tendermint => github.com/cometbft/cometbft v0.34.31 | |||
| replace github.com/tendermint/tendermint => github.com/cometbft/cometbft v0.34.34 | |||
There was a problem hiding this comment.
Suggested change
| replace github.com/tendermint/tendermint => github.com/cometbft/cometbft v0.34.34 | |
| replace github.com/tendermint/tendermint => github.com/cometbft/cometbft v0.34.35 |
looks like the latest is v0.34.35
Comment on lines
+45
to
+47
| google.golang.org/genproto/googleapis/api v0.0.0-20240311132316-a219d84964c2 | ||
| google.golang.org/grpc v1.65.0 | ||
| google.golang.org/protobuf v1.34.2 |
There was a problem hiding this comment.
hmm, a bump in these versions might be breaking stuff
|
close due to deps have non backward compatible api changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AXE-4742
Todos
Steps to Test
Expected Behaviour
Other Notes